[U-Boot] [PATCH] mx25: fix the offset between the USB ports' registers

[Fabio Estevam]

Hi Martin,

Thanks for the patch!

On Fri, Jul 13, 2018 at 5:02 AM, Martin Kaiser <lists at kaiser.cx> wrote:
> From: Martin Kaiser <martin at kaiser.cx>
>
> The USBOH module on imx25 chips contains two USB controllers, which are
> called USB OTG Controller and USB Host Controller. Each one has its EHCI
> root hub. The OTG Controller's EHCI registers start at offset 0, the Host
> Controller's registers start at offset 0x400.
>
> We set CONFIG_MXC_USB_PORT=0 to select the OTG Controller and 1 for the
> Host Controller. Therefore, IMX_USB_PORT_OFFSET must be 0x400. Using
> this setting, the Host Controller starts working on my imx25 board.
>
> Please note that the imx25 reference manual claims that the Host
> Controller's registers start at 0x200. This is not correct. The Linux
> Kernel uses the correct offset 0x400 in imx25.dtsi.
>
> Signed-off-by: Martin Kaiser <martin at kaiser.cx>
> ---
>  arch/arm/include/asm/arch-mx25/imx-regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h
> index 1b00ed7..8d08a85 100644
> --- a/arch/arm/include/asm/arch-mx25/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h
> @@ -360,7 +360,7 @@ struct cspi_regs {
>  #define IMX_IIM_BASE           (0x53FF0000)
>  #define IIM_BASE_ADDR          IMX_IIM_BASE
>  #define IMX_USB_BASE           (0x53FF4000)
> -#define IMX_USB_PORT_OFFSET    0x200
> +#define IMX_USB_PORT_OFFSET    0x400

Could you also add some comments here?

Something like you wrote in the commit log would help.

This way we avoid in the future someone trying to fix the mismatch
between the Reference Manual and the code definition.

With that added:

Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>