[U-Boot] [PATCH] serial: ns16550: Add register shift variable

Adam Ford aford173 at gmail.com
Tue Jul 17 21:30:45 UTC 2018


On Tue, Jul 17, 2018 at 4:24 PM Andy Shevchenko
<andy.shevchenko at gmail.com> wrote:
>
> On Tue, Jul 17, 2018 at 4:34 PM, Alexey Brodkin
> <Alexey.Brodkin at synopsys.com> wrote:
>
> >> Linux has a completely separate driver for omap3 (which is wrong too).
>
> This is not (fully) correct,
>
> >> But in a nutshell, it basically determines the shift value by the
> >> "compatible" string, so we should too.
> >
> > Here's the driver:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/omap-serial.c
>
> I dunno why it's still in the tree. The modern one is (check
> compatible strings for both):
>
> https://elixir.bootlin.com/linux/v4.18-rc5/source/drivers/tty/serial/8250/8250_omap.c
>
>
Can we omap2+ users patch the 8250_omap.c code in Linux to make use of
the reg-shift, then do the same from u-boot so they are in sync and
clean out any #defines that could be replaced by the device tree?

(I am not volunteering anyone or myself, it's more of a hypothetical question)

adam

>
>
> --
> With Best Regards,
> Andy Shevchenko
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot


More information about the U-Boot mailing list