[U-Boot] [PATCH] omap3: beagle: re-enable EFI support after the following commit removed it by mistake:

Derald D. Woods woods.technical at gmail.com
Wed Jul 18 23:47:20 UTC 2018


On Wed, Jul 18, 2018 at 09:38:44PM +0200, Guillaume GARDET wrote:
>   commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b
>   ARM: omap3: beagle: Enable DM_SERIAL, update distro usage and NAND layout


I have found no compile or runtime issues, on my BeagleBoard Rev. C4
or xM, with the current default configuration. At least, for my non-EFI
boot environment.

The following items are brought in from the EFI config additions:

+CONFIG_SMBIOS_PRODUCT_NAME="beagle"
+CONFIG_CMD_BOOTEFI=y
+CONFIG_CMD_BOOTEFI_HELLO_COMPILE=y
+CONFIG_EFI_PARTITION=y
+CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=128
+CONFIG_EFI_PARTITION_ENTRIES_OFF=0
+CONFIG_SPL_EFI_PARTITION=y
+CONFIG_OF_LIBFDT_OVERLAY=y
+CONFIG_GENERATE_SMBIOS_TABLE=y
+CONFIG_SMBIOS_MANUFACTURER="ti"
+CONFIG_EFI_LOADER=y

I would change the commit message though. It was not a mistake. It was
removed to provide a minimal set of configuration options for the base
BSP type of setup. Using EFI is a choice. In fact, I tested my changes
on 3 different OMAP3 boards. So there has been no period of not working
in the basic board configuration. Provably.

So if EFI is required, even though one may not use it, this is a don't
care for me. My boards boot just fine without EFI.

Derald

> Signed-off-by: Guillaume GARDET <guillaume.gardet at free.fr>
> Cc: Derald D. Woods <woods.technical at gmail.com>
> Cc: Tom Rini <trini at konsulko.com> 
> 
> ---
>  configs/omap3_beagle_defconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/configs/omap3_beagle_defconfig b/configs/omap3_beagle_defconfig
> index a37a38f881..1e1a391d7f 100644
> --- a/configs/omap3_beagle_defconfig
> +++ b/configs/omap3_beagle_defconfig
> @@ -32,8 +32,6 @@ CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
>  CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:512k(spl),1920k(u-boot),128k(u-boot-env),128k(dtb),6m(kernel),-(rootfs)"
>  CONFIG_CMD_UBI=y
>  # CONFIG_ISO_PARTITION is not set
> -# CONFIG_EFI_PARTITION is not set
> -CONFIG_SPL_PARTITION_UUIDS=y
>  CONFIG_OF_CONTROL=y
>  CONFIG_ENV_IS_IN_NAND=y
>  CONFIG_SPL_DM=y
> @@ -79,4 +77,3 @@ CONFIG_USB_ETHER_SMSC95XX=y
>  CONFIG_FAT_WRITE=y
>  CONFIG_BCH=y
>  CONFIG_SPL_OF_LIBFDT=y
> -# CONFIG_EFI_LOADER is not set
> -- 
> 2.18.0
> 


More information about the U-Boot mailing list