[U-Boot] [PATCH 3/4] x86: fsp: Eliminate the reset_cpu() call

Bin Meng bmeng.cn at gmail.com
Thu Jul 19 05:33:51 UTC 2018


Hi Simon,

On Mon, Jul 9, 2018 at 10:39 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 3 July 2018 at 02:48, Bin Meng <bmeng.cn at gmail.com> wrote:
>> In preparation for the reset driver conversion, eliminate the
>> reset_cpu() call in the FSP init path as it's too early for the
>> reset driver to work.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  arch/x86/lib/fsp/fsp_common.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> But it would be good to have a comment explaining this in the code.

There is already a comment /* Reboot */ before the debug() call.

Regards,
Bin


More information about the U-Boot mailing list