[U-Boot] [PATCH v2] Add Beaglebone Enhanced support

Koen Kooi koen at dominion.thruhere.net
Thu Jul 19 13:03:16 UTC 2018



> Op 19 jul. 2018, om 15:02 heeft Tom Rini <trini at konsulko.com> het volgende geschreven:
> 
> On Thu, Jul 19, 2018 at 02:55:37PM +0200, Marek Vasut wrote:
>> On 07/18/2018 10:13 AM, Koen Kooi wrote:
>>> The "Beaglebone Enhanced" by Sancloud is based on the Beaglebone Black,
>>> but with the following differences:
>>> 
>>> * Gigabit capable PHY
>>> * Extra USB hub, optional i2c control
>>> * lps3331ap barometer connected over i2c
>>> * MPU6050 6 axis MEMS accelerometer/gyro connected over i2c
>>> * 1GiB DDR3 RAM
>>> * RTL8723 Wifi/Bluetooth connected over USB
>>> 
>>> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
>>> 
>>> ---
>>> 
>> [...]
>> 
>>> diff --git a/board/ti/am335x/board.h b/board/ti/am335x/board.h
>>> index 652b10b..48df914 100644
>>> --- a/board/ti/am335x/board.h
>>> +++ b/board/ti/am335x/board.h
>>> @@ -43,9 +43,15 @@ static inline int board_is_bbg1(void)
>>> 	return board_is_bone_lt() && !strncmp(board_ti_get_rev(), "BBG1", 4);
>>> }
>>> 
>>> +static inline int board_is_bben(void)
>> 
>> Should be just static int ... the compiler can decide.
> 
> No, it should be inline like all of the others in the file are.  And
> then yes, if someone wants to do a size comparison with or without
> inlining on all of those functions, sure.

I wasn’t clear in my reply, I have a seperate patch that converts all of them :)

regards,

Koen

> 
> -- 
> Tom



More information about the U-Boot mailing list