[U-Boot] [PATCH V2 29/32] fsl_esdhc: Update usdhc driver to support i.MX8

Peng Fan peng.fan at nxp.com
Thu Jul 19 14:04:58 UTC 2018


Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: 2018年7月19日 22:01
> To: Peng Fan <peng.fan at nxp.com>
> Cc: Stefano Babic <sbabic at denx.de>; Fabio Estevam
> <fabio.estevam at nxp.com>; U-Boot-Denx <u-boot at lists.denx.de>; dl-linux-imx
> <linux-imx at nxp.com>
> Subject: Re: [U-Boot] [PATCH V2 29/32] fsl_esdhc: Update usdhc driver to
> support i.MX8
> 
> On Tue, Jul 17, 2018 at 10:35 PM, Peng Fan <peng.fan at nxp.com> wrote:
> > From: Ye Li <ye.li at nxp.com>
> >
> > Add CONFIG_ARCH_IMX8 to use the 64bits support in usdhc driver.
> >
> > Signed-off-by: Ye Li <ye.li at nxp.com>
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > Cc: Jaehoon Chung <jh80.chung at samsung.com>
> > ---
> >  drivers/mmc/fsl_esdhc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index
> > 4528345c67..785b9e87a6 100644
> > --- a/drivers/mmc/fsl_esdhc.c
> > +++ b/drivers/mmc/fsl_esdhc.c
> > @@ -257,7 +257,7 @@ static int esdhc_setup_data(struct fsl_esdhc_priv
> *priv, struct mmc *mmc,
> >         int timeout;
> >         struct fsl_esdhc *regs = priv->esdhc_regs;  #if
> > defined(CONFIG_FSL_LAYERSCAPE) || defined(CONFIG_S32V234) || \
> > -       defined(CONFIG_MX8M)
> > +       defined(CONFIG_ARCH_IMX8) || defined(CONFIG_MX8M)
> 
> I am a bit confused: why do we need the || here?
> 
> Doesn't CONFIG_ARCH_IMX8 also relate to MX8M?

There is i.MX8/8X/8M, 8M is for i.MX8MQ and i.MX8MM
i.MX8/8X has different SoC architecture compared with i.MX8M,
such as there is SCU inside i.MX8/8X.
So add a new macro dedicated for i.MX8/8X.

Thanks,
Peng.


More information about the U-Boot mailing list