[U-Boot] [U-Boot, 2/6] board: ge: Move VPD EEPROM configuration to the defconfig

Sebastian Reichel sebastian.reichel at collabora.co.uk
Thu Jul 19 21:47:12 UTC 2018


Hi Tom,

On Thu, Jul 19, 2018 at 04:31:01PM -0400, Tom Rini wrote:
> On Tue, Jun 26, 2018 at 07:43:00PM +0200, Sebastian Reichel wrote:
> 
> > From: Denis Zalevskiy <denis.zalevskiy at ge.com>
> > 
> > Use standard configuration logic to define EEPROM constants. Names are based on
> > VPD_EEPROM_ prefix because EEPROM_ is already used by i2c_eeprom driver.
> > 
> > Signed-off-by: Denis Zalevskiy <denis.zalevskiy at ge.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.co.uk>
> > ---
> >  board/ge/bx50v3/Kconfig     |  2 ++
> >  board/ge/bx50v3/bx50v3.c    | 17 ++++-------------
> >  board/ge/mx53ppd/Kconfig    |  2 ++
> >  board/ge/mx53ppd/mx53ppd.c  | 14 ++++----------
> >  configs/ge_bx50v3_defconfig |  9 +++++++++
> >  configs/mx53ppd_defconfig   | 10 ++++++++++
> >  6 files changed, 31 insertions(+), 23 deletions(-)
> > 
> > diff --git a/board/ge/bx50v3/Kconfig b/board/ge/bx50v3/Kconfig
> > index 993b0559302b..05938560abda 100644
> > --- a/board/ge/bx50v3/Kconfig
> > +++ b/board/ge/bx50v3/Kconfig
> > @@ -15,4 +15,6 @@ config SYS_SOC
> >  config SYS_CONFIG_NAME
> >  	default "ge_bx50v3"
> >  
> > +source "board/ge/common/Kconfig"
> 
> The new file board/ge/common/Kconfig is missing, please repost the
> series with the file added, thanks!

Oops, I just wondered how my test-built worked, but it's just me
being too stupid to read git output 😓

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	board/ge/common/Kconfig

Anyways, thanks for the review, I will resend the series!

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180719/8e795f68/attachment.sig>


More information about the U-Boot mailing list