[U-Boot] [PATCH 1/2] env: Don't print "Failed" error message

Sam Protsenko semen.protsenko at linaro.org
Fri Jul 20 14:54:55 UTC 2018


On Fri, Jul 20, 2018 at 4:29 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Sam,
>
> In message <20180720131421.7136-2-semen.protsenko at linaro.org> you wrote:
>>
>> +             if (!ret)
>>                       printf("OK\n");
>>
>>               if (!ret)
>
> Now we have two "if (!ret)" in sequence.  Make this one block,
> please.
>

Good point. Will do in v2, thanks.

> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Commitment, n.:      Commitment can be illustrated by a breakfast
> of ham and eggs. The chicken was involved, the pig was committed.


More information about the U-Boot mailing list