[U-Boot] [U-Boot, 3/4] dm: led: move default state support in led uclass

Patrick DELAUNAY patrick.delaunay at st.com
Fri Jul 20 17:14:53 UTC 2018


Hi Tom

> From: Tom Rini <trini at konsulko.com>
> Sent: vendredi 20 juillet 2018 15:54
> 
> On Fri, Jul 13, 2018 at 05:21:10PM +0200, Patrick Delaunay wrote:
> 
> > This patch save common LED property "default-state" value in post bind
> > of LED uclass.
> >
> > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Making the change like this breaks (and leaves broken) the default state test in
> test/dm/led.c so 'make tests' fails.  Please rework the series to include fixing the
> test, thanks!

Sorry for the disturbance...

I tried this compilation but I was blocked by lib SDL issues and other configuration on my PC and I push the patch without test execution.  
Today I take the time to solve my compilation issue and I reproduce the test error.

I will push a corrective version of this patch next Monday.

Today I add a board_init function for sandbox arch to call the added function... it is now working in sandbox:
	./u-boot -d ./arch/sandbox/dts/test.dtb

but I have still issue with test.... because board_init() is not called.

> --
> Tom

Patrick


More information about the U-Boot mailing list