[U-Boot] [U-Boot,V3,1/2] spl: Fix redundant image of uboot

[Michael Nazzareno Trimarchi]

Hi Tom

On Fri, Jul 20, 2018 at 9:54 PM, Tom Rini <trini at konsulko.com> wrote:
> On Fri, Jul 06, 2018 at 05:09:22PM +0200, Michael Trimarchi wrote:
>
>> We need to address the redundat image case and undestand if the
>> image is corrupted or not. In error case we need to try the fallback copy.
>> The function used before was always return 0 without any evaluation of the
>> error. We try to make it work properly
>>
>> Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
>> ---
>> Changes V2->V3:
>>         Fix patch mistake due the a wrong edit of it
>> Changes V1->V2:
>>         Address the comments on using the err variable
>> ---
>>  common/spl/spl_nand.c | 34 +++++++++++++++++++++++++---------
>>  1 file changed, 25 insertions(+), 9 deletions(-)
>
> I see two problems here.  First, this is a generic issue (any
> legacy-style U-Boot image that we load should be verified).  Second, we
> need to make this behavior configurable as as-is this overflows one
> board (omapl138_lcdk) and I expect would be problematic for many more
> boards when we make it done more commonly.
>

This patch fix a no-working uboot feature and this was the address problem on
the specific case. We can call ->verify image every ->load, anyway can you
explain better why you need a configurable behavior?

Michael

> --
> Tom



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |