[U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling

Michal Simek michal.simek at xilinx.com
Mon Jul 23 13:56:07 UTC 2018


On 23.7.2018 14:15, Tom Rini wrote:
> On Mon, Jul 23, 2018 at 08:40:51AM +0200, Michal Simek wrote:
>> On 20.7.2018 14:53, Tom Rini wrote:
>>> On Fri, Jul 20, 2018 at 02:05:07PM +0200, Michal Simek wrote:
>>>
>>>> CMD_DM is used for debug purpose and it shouldn't be enabled by default
>>>> via Kconfig. Unfortunately this is in the tree for quite a long time
>>>> that's why solution is to use imply DM for all targets which are
>>>> enabling DM.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>> ---
>>>>
>>>> Based on this discussion:
>>>> https://lists.denx.de/pipermail/u-boot/2018-July/334952.html
>>>>
>>>> Done by:
>>>> for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
>>>> uniq`; do
>>>> 	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
>>>> done
>>>
>>> OK, I'm glad you did this, but now the (mostly) sorted lists are
>>> un-sorted.  Please update to keep them alphabetically sorted, thanks!
>>
>> How this should be sorted?
>> sorted "select" list first followed by sorted "imply" list?
> 
> Yes, that's approximately how I've been doing it.  It won't be 100%
> sorted as some arches aren't, but it should be close.  Thanks again!

Ok. Patches sent. I have done some sorting before this patch.

Thanks,
Michal


More information about the U-Boot mailing list