[U-Boot] [PATCH v2 4/5] stm32mp1: use new function led default state

Simon Glass sjg at chromium.org
Mon Jul 23 23:47:55 UTC 2018


On 23 July 2018 at 03:41, Patrick Delaunay <patrick.delaunay at st.com> wrote:
> Initialize the led with the default state defined in device tree.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
> Changes in v2: None
>
>  board/st/stm32mp1/stm32mp1.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>

But I wonder if you can use if (IS_ENABLED(CONFIG_LED)) instead?
>
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index cc39fa6..db8c805 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -22,5 +22,9 @@ int board_init(void)
>         /* address of boot parameters */
>         gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
>
> +#ifdef CONFIG_LED
> +       led_default_state();
> +#endif /* CONFIG_LED */
> +
>         return 0;
>  }
> --
> 2.7.4
>


More information about the U-Boot mailing list