[U-Boot] [PATCH 11/20] w1: enumerate sandbox driver if configured

[Simon Glass]

Hi,

On 20 July 2018 at 08:01, Lukasz Majewski <lukma at denx.de> wrote:
> Hi Eugen,
>
> Thanks for (re-)bringing the One wire support to u-boot.
>
>> Add a sandbox eeprom on the bus as a device, if sandbox driver is
>> configured.
>>
>> Signed-off-by: Eugen Hristev <eugen.hristev at microchip.com>
>> ---
>>  drivers/w1/w1-uclass.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/w1/w1-uclass.c b/drivers/w1/w1-uclass.c
>> index cfddda3..e58c1ca 100644
>> --- a/drivers/w1/w1-uclass.c
>> +++ b/drivers/w1/w1-uclass.c
>> @@ -142,6 +142,11 @@ static int w1_enumerate(struct udevice *bus)
>>               }
>>       }
>>
>> +#ifdef CONFIG_W1_EEPROM_SANDBOX
>> +     /* before we are finished, add a sandbox device if we can */
>> +     w1_new_device(bus, W1_FAMILY_EEP_SANDBOX);
>> +#endif
>
> IMHO we shouldn't mix the sandbox code with production (on boards) code.
>
> Maybe Simon (+CCed) could provide some more input here?

I have not seen this series. But new devices should be created
automatically based on them being in the device tree. So you should
just be able to add them there.

I don't understand what w1_new_device() does. Also, it should return an error.

Regards,
Simon