[U-Boot] [PATCH V2 29/32] fsl_esdhc: Update usdhc driver to support i.MX8

[Peng Fan]

Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: 2018年7月24日 3:27
> To: Peng Fan <peng.fan at nxp.com>
> Cc: Stefano Babic <sbabic at denx.de>; Fabio Estevam
> <fabio.estevam at nxp.com>; U-Boot-Denx <u-boot at lists.denx.de>; dl-linux-imx
> <linux-imx at nxp.com>
> Subject: Re: [U-Boot] [PATCH V2 29/32] fsl_esdhc: Update usdhc driver to
> support i.MX8
> 
> Hi Peng,
> 
> On Thu, Jul 19, 2018 at 11:04 AM, Peng Fan <peng.fan at nxp.com> wrote:
> 
> > There is i.MX8/8X/8M, 8M is for i.MX8MQ and i.MX8MM i.MX8/8X has
> > different SoC architecture compared with i.MX8M, such as there is SCU
> > inside i.MX8/8X.
> > So add a new macro dedicated for i.MX8/8X.
> 
> Yes, I understand the differences between the MX8 family.
> 
> Couldn't you make CONFIG_IMX8 instead of CONFIG_ARCH_IMX8 for
> consistency?

In V1, I use CONFIG_IMX8, but I think there is no need to use it, because
CONFIG_ARCH_IMX8 could do same thing.

I could revert to use CONFIG_IMX8, since you prefer it.

> 
> Also, for consistency: should CONFIG_MX8M be changed to CONFIG_IMX8M?

Yes. CONFIG_MX8M also need to be changed to CONFIG_IMX8M, but not in this patchset.

Thanks,
Peng.

> 
> Thanks