[U-Boot] [PATCH v2 6/6] mmc: arm_pl180_mmci: Add "cd_inverted" DT property read

Patrice CHOTARD patrice.chotard at st.com
Tue Jul 24 11:42:52 UTC 2018


Hi Tuomas

On 07/24/2018 01:22 PM, Tuomas Tynkkynen wrote:
> Hi Patrice,
> 
> 
> On 07/24/2018 12:39 PM, Patrice Chotard wrote:
>> Add missing read of "cd_inverted" property in DT.
>>
> 
> If your platform uses GPIOs for card detection, it's
> simpler and more readable to use GPIO_ACTIVE_(LOW|HIGH)
> in the gpio flags instead of using the cd-inverted
> property. See Linux commit 45e01f401a2a16a8d7 where this
> was done for sunxi). Then this commit isn't needed.

Thanks for pointing this ;-)
I will submit a v3

Patrice

> 
> - Tuomas


More information about the U-Boot mailing list