[U-Boot] [PATCH] tools: genboardscfg: move buildman path to first

Peng Fan peng.fan at nxp.com
Wed Jul 25 02:51:53 UTC 2018


Hi Simon,

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: 2018年7月25日 10:45
> To: Peng Fan <peng.fan at nxp.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; dl-linux-imx
> <linux-imx at nxp.com>; Masahiro Yamada <yamada.m at jp.panasonic.com>;
> Tom Rini <trini at konsulko.com>
> Subject: Re: [PATCH] tools: genboardscfg: move buildman path to first
> 
> Hi Peng,
> 
> On 24 July 2018 at 00:27, Peng Fan <peng.fan at nxp.com> wrote:
> > To system which has kconfiglib installed, genboardscfg will use system
> > kconfiglib, we need it use U-Boot owned version, so move the buildman
> > path to first.
> >
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > Cc: Masahiro Yamada <yamada.m at jp.panasonic.com>
> > Cc: Simon Glass <sjg at chromium.org>
> > Cc: Tom Rini <trini at konsulko.com>
> > ---
> >  tools/genboardscfg.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index
> > 0648472af0..e9bbd15e15 100755
> > --- a/tools/genboardscfg.py
> > +++ b/tools/genboardscfg.py
> > @@ -24,7 +24,7 @@ import sys
> >  import tempfile
> >  import time
> >
> > -sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman'))
> > +sys.path.insert(1, os.path.join(os.path.dirname(__file__),
> > +'buildman'))
> 
> How come you insert this second in the list rather than first? If that is deliberate,
> can you please add a comment?

Do you mean I need to use `sys.path.insert(0, os.path.join(os.path.dirname(__file__), +'buildman'))`?

I print my sys.path, the first is '', So I follow other code in uboot, and use '1' here.

Thanks,
Peng.

> 
> >  import kconfiglib
> >
> >  ### constant variables ###
> > --
> > 2.14.1
> >
> 
> Regards,
> Simon


More information about the U-Boot mailing list