[U-Boot] [PATCH] spl: fit: Enable GZIP compression also for no kernel partitions

Simon Goldschmidt sgoldschmidt at de.pepperl-fuchs.com
Wed Jul 25 06:52:49 UTC 2018


On 25.07.2018 08:40, Michal Simek wrote:
> On 25.7.2018 08:26, Simon Goldschmidt wrote:
>>
>>
>> On 24.07.2018 15:07, Michal Simek wrote:
>>> There is no reason to limit gzip usage only for OS_BOOT and kernel image
>>> type. >
>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>> ---
>>>
>>>    common/spl/spl_fit.c | 5 +----
>>>    1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>> diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
>>> index 9eabb1c1058b..dbf5ac33a845 100644
>>> --- a/common/spl/spl_fit.c
>>> +++ b/common/spl/spl_fit.c
>>> @@ -257,10 +257,7 @@ static int spl_load_fit_image(struct
>>> spl_load_info *info, ulong sector,
>>>        board_fit_image_post_process(&src, &length);
>>>    #endif
>>>    -    if (IS_ENABLED(CONFIG_SPL_OS_BOOT)    &&
>>> -        IS_ENABLED(CONFIG_SPL_GZIP)        &&
>>> -        image_comp == IH_COMP_GZIP        &&
>>> -        type == IH_TYPE_KERNEL) {
>>> +    if (IS_ENABLED(CONFIG_SPL_GZIP) && image_comp == IH_COMP_GZIP) {
>>>            size = length;
>>>            if (gunzip((void *)load_addr, CONFIG_SYS_BOOTM_LEN,
>>>                   src, &size)) {
>>>
>>
>> I suppose this is to support a gziped fpga image in a fit. Does this
>> work for U-Boot proper already?
> 
> Luis has tested it some days ago based on my suggestion. I have tried
> that yesterday on zynq zc706 and it was also working for internal data.
> Please take a look at second thread where also times are listed.

Isn't that 2nd thread on SPL also? I was asking for U-Boot proper in 
comparison.

We are programming the FPGA from U-Boot proper, not SPL, using a 
Multi-config FIT image including matching Kernel and Device tree. And 
here, using a gziped FPGA might be nice. But from reading the sources (I 
think I also tested it once), that doesn't work. That's why I ask.

Simon


More information about the U-Boot mailing list