[U-Boot] [PATCH 3/4] gpio: xilinx: Not read output values via regs

[Michal Simek]

On 25.7.2018 20:21, Stefan Herbrechtsmeier wrote:
> Am 25.07.2018 um 08:39 schrieb Michal Simek:
>> On 24.7.2018 21:56, Stefan Herbrechtsmeier wrote:
>>> Am 24.07.2018 um 12:31 schrieb Michal Simek:
>>>> On 23.7.2018 20:42, Stefan Herbrechtsmeier wrote:
>>>>> Am 23.07.2018 um 13:43 schrieb Michal Simek:
>>>>>> Reading registers for finding out output value is not working because
>>>>>> input value is read instead in case of tristate.
>>>>>>
>>>>>> Reported-by: Stefan Herbrechtsmeier <stefan at herbrechtsmeier.net>
>>>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>>>> ---
>>>>>>
>>>>>>     drivers/gpio/xilinx_gpio.c | 38
>>>>>> +++++++++++++++++++++++++++++++++-----
>>>>>>     1 file changed, 33 insertions(+), 5 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/gpio/xilinx_gpio.c b/drivers/gpio/xilinx_gpio.c
>>>>>> index 4da9ae114d87..9d3e9379d0e5 100644
>>>>>> --- a/drivers/gpio/xilinx_gpio.c
>>>>>> +++ b/drivers/gpio/xilinx_gpio.c
>>> [snip]
>>>
>>>>>>     +    priv->output_val[bank] = val;
>>>>>> +
>>>>>>         return val;
>>>>>>     };
>>>>>>     @@ -441,6 +449,7 @@ static int xilinx_gpio_get_function(struct
>>>>>> udevice *dev, unsigned offset)
>>>>>>     static int xilinx_gpio_get_value(struct udevice *dev, unsigned
>>>>>> offset)
>>>>>>     {
>>>>>>         struct xilinx_gpio_platdata *platdata =
>>>>>> dev_get_platdata(dev);
>>>>>> +    struct xilinx_gpio_privdata *priv = dev_get_priv(dev);
>>>>>>         int val, ret;
>>>>>>         u32 bank, pin;
>>>>>>     @@ -451,7 +460,14 @@ static int xilinx_gpio_get_value(struct
>>>>>> udevice
>>>>>> *dev, unsigned offset)
>>>>>>         debug("%s: regs: %lx, gpio: %x, bank %x, pin %x\n", __func__,
>>>>>>               (ulong)platdata->regs, offset, bank, pin);
>>>>>>     -    val = readl(&platdata->regs->gpiodata + bank * 2);
>>>>>> +    if (xilinx_gpio_get_function(dev, offset) == GPIOF_INPUT) {
>>>>>> +        debug("%s: Read input value from reg\n", __func__);
>>>>>> +        val = readl(&platdata->regs->gpiodata + bank * 2);
>>>>>> +    } else {
>>>>>> +        debug("%s: Read saved output value\n", __func__);
>>>>>> +        val = priv->output_val[bank];
>>>>>> +    }
>>>>> Why you don't always read the data register? This doesn't work for
>>>>> three
>>>>> state outputs.
>>>> In three state register every bit/pin is 0 - output, 1 input.
>>>> It means else part is output and I read saved value in
>>>> priv->output_val.
>>>> If pin is setup as INPUT then I need read data reg to find out input
>>>> value.
>>>> Maybe you are commenting something else but please let me know if there
>>>> is any other bug.
>>> What happen if I have an open drain output. Even if the gpio output is 1
>>> the input could read a 0. You driver will always return the output value
>>> and not the real input value. According to the picture in documentation
>>> and my tests a data register write writes the output registers and a
>>> data register read reads the input registers.
>>>
>>> Why should the driver return the desired state (output register) and not
>>> the real state (input register)?
>> First of all thanks for description.
>>
>> I have another example where you have output only and you can't read
>> input because there is no wire.
> 
> Does you mean the all outputs configuration? Does this removes the
> "gpio_io_i" signal from the IP?

I am not sure what synthesis is doing with that unused IP pins but I
would consider as a bug if this is automatically connected together. And
also wasting a logic if there is unused part.
But in Vivado you should be able to setup output pins to and input pins
separately. There are In/Out/Tristate.
If you don't want to deal with external pin you can connect them inside PL.


>> Regarding open drain output.
>>
>> Also this is what it is written in manual:
>> "AXI GPIO Data Register Description"
>> "For each I/O bit programmed as output:
>> • R: Reads to these bits always return zeros"
> 
> This must be a mistake in the documentation. I could read the input value.
> 
> The old driver and the Linux driver always read the register.

In old u-boot driver I see
 179         if (gpio_get_direction(gpio) == GPIO_DIRECTION_OUT)
 180                 val = gpio_get_output_value(gpio);
 181         else
 182                 val = gpio_get_input_value(gpio);

gpio_get_output_value() reads it from gpiodata_store for output
gpio_get_input_value() reads the reg.

In Linux you are right it is read from reg in both cases.

> 
> Additionally the documentation states that a write to an input doesn't
> work:
> AXI GPIO Data Register.
> For each I/O bit programmed as input:
> •  R: Reads value on the input pin.
> •  W: No effect.
> 
> However the Linux driver use the common sequence and sets first the data
> register and afterwards the direction register.

Possible that driver has pretty long history and I don't think it was
tested for all cases.

>> If you want to support this configuration then you would have to change
>> pin to input and read it and revert it back. And all of this should be
>> done based on flag.
>> There is macro GPIO_OPEN_DRAIN which could be specified via DT binding.
>> Unfortunately this is for consumer not for generic listing. I can't also
>> see it in gpio_desc flags to be able to handle it in the driver.
>> That's why I have doubts if this is supported by any u-boot gpio driver
>> but I can be wrong.
> 
> I think the GPIO_OPEN_DRAIN is used to not set the output to 1. In our
> case the open drain is transparent. The output has only two states
> High-Z and 0. The input value of the FPGA output block is always 0 and
> the tri-state input is connected to the output register of the GPIO
> controller. The output of the FPGA input block is connected to the input
> register of the GPIO controller.

I just found out in connection to second thread we have together that in
gpio-uclass there are dm_gpio_set/get_open_drain functions but they are
not wired anywhere.
I think in your case when these two functions are implemented you will
get this functionality which you are asking about.

My guess is that gpio command should be extended to call these two
functions. When set_open_drain is called special flag for pin is setup
and for this pin get_status will always read data reg in our case and
you get your values.

Thanks,
Michal