[U-Boot] [PATCH v1 07/17] cmd: fpga: Remove parameter checking from fpga loadfs command

Michal Simek michal.simek at xilinx.com
Thu Jul 26 14:16:29 UTC 2018


Parameter checking is dead code because all the time there must be all
params assigned. If they are not assigned there is no 9th parameters
passed and checking before return CMD_RET_USAGE.

Signed-off-by: Michal Simek <michal.simek at xilinx.com>
Reviewed-by: Simon Glass <sjg at chromium.org>
---

Changes in v1: None

 cmd/fpga.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/cmd/fpga.c b/cmd/fpga.c
index 48902286f1d5..b03dd9dc0ace 100644
--- a/cmd/fpga.c
+++ b/cmd/fpga.c
@@ -124,13 +124,6 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 		fpga_fsinfo.dev_part = argv[7];
 		fpga_fsinfo.filename = argv[8];
 
-		/* Blocksize can be zero */
-		if (!fpga_fsinfo.interface || !fpga_fsinfo.dev_part ||
-		    !fpga_fsinfo.filename) {
-			puts("ERR: Wrong interface, dev_part or filename\n");
-			return CMD_RET_USAGE;
-		}
-
 		argc = 5;
 		break;
 #endif
-- 
1.9.1



More information about the U-Boot mailing list