[U-Boot] [PULL] efi patch queue 2018-07-25

[Heinrich Schuchardt]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 07/28/2018 06:32 PM, Tom Rini wrote:
> On Sat, Jul 28, 2018 at 06:21:58PM +0200, Heinrich Schuchardt
> wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
>> 
>> On 07/28/2018 06:13 PM, Tom Rini wrote:
>>> On Sat, Jul 28, 2018 at 06:07:20PM +0200, Heinrich Schuchardt 
>>> wrote:
>>> 
>>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
>>>> 
>>>> On 07/28/2018 05:55 PM, Tom Rini wrote:
>>>>> On Wed, Jul 25, 2018 at 03:04:27PM +0200, Alexander Graf 
>>>>> wrote:
>>>>> 
>>>>>> Hi Tom,
>>>>>> 
>>>>>> This is my current patch queue for efi.  Please pull.
>>>>>> 
>>>>>> Alex
>>>>>> 
>>>>>> 
>>>>>> The following changes since commit 
>>>>>> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784:
>>>>>> 
>>>>>> mtd: nand: add new enum for storing ECC algorithm 
>>>>>> (2018-07-23 14:33:21 -0400)
>>>>>> 
>>>>>> are available in the git repository at:
>>>>>> 
>>>>>> git://github.com/agraf/u-boot.git tags/signed-efi-next
>>>>>> 
>>>>>> for you to fetch changes up to 
>>>>>> 0b8a88ab6aa24de0ef2bf1e8109409f71e770a8e:
>>>>>> 
>>>>>> MAINTAINERS: assign lib/charset.c (2018-07-25 15:00:24 
>>>>>> +0200)
>>>>>> 
>>>>> 
>>>>> NAK, this breaks one of the filesystem tests.
>>>>> Specifically: commit
>>>>> 0dc1bfb7302d220a48364263d5632d6d572b069b Author: Heinrich
>>>>> Schuchardt <xypron.glpk at gmx.de> Date:   Mon Jul 2 02:41:23
>>>>> 2018 +0200
>>>>> 
>>>>> fs: fat: cannot write to subdirectories
>>>>> 
>>>>> Breaks TC13: 1MB write to ./1MB.file.w2
>>>>> 
>>>> 
>>>> Hello Tom,
>>>> 
>>>> please, provide the link to the Travis log with the failure.
>>> 
>>> It's actually not in travis.  Running test/fs/fs-test.sh is 
>>> annoying to automate: FSTST=`./test/fs/fs-test.sh 2>&1 | tail
>>> -n 3 | head -n 1` echo $FSTST | grep -q "TOTAL PASS: 204 TOTAL
>>> FAIL: 12" && exit 0 || exit 1
>>> 
>>> but I should see if I can get that into .travis.yml.
>>> 
>> 
>> ./test/fs/fs-test.sh Missing mkfs binary. Exiting!
>> 
>> You wouldn't run tests as root? Is this test meant to be run
>> with fakeroot?
> 
> It requires sudo to work along with various utilities to make the 
> various filesystems.
> 

Tom please, have a look at the files created by the tests w/o my patch.

This is what the find command returns:

sandbox/test/fs/mnt
sandbox/test/fs/mnt/SUBDIR
sandbox/test/fs/mnt/2.5GB.file
sandbox/test/fs/mnt/1MB.file
sandbox/test/fs/mnt/1MB.file.w
sandbox/test/fs/mnt/1MB.file.w2
sandbox/test/fs/mnt/./1MB.file.w2

You observe that the last file has an illegal file name (yes, the
filename itself is "./1MB.file.w2". It should never have been created.

Without my patch this illegal file is not created.

Why should this be a reason to dismiss my patch?

Best regards

Heinrich
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEbcT5xx8ppvoGt20zxIHbvCwFGsQFAltco4YACgkQxIHbvCwF
GsSTxhAAhPbNHg16YZg7DZE6pMPZ5v64eVrAPPiM6LoIb8rXyLtKP9lDh/V1tk33
t7nHRfPfS5Ow3KYjneBxoxnw3A4uxU4Rf16xb5KZX9UvLPUusumwjaRUW9/FytiQ
MkZeZQGdtAHLy9cFL3sRkIM4Vz3kWo5XBNgYjJaYQAN0/BlWt6oknTUKAYrciGCz
O+B7i6Vf7hXj1d1RdFjLfS4sinSibjUMd1Bn5HoAZvjLo3Gfmi+e/ZIPXKb75QfP
fQwH6oGuEOL6WqL+OyS5CVXiBeGbOtrJoH7o5C8TEixcPwp2cKGP7p/L8UBIOBbM
a/zXIgumFZhAyDhRdLcvevvUxfBRX4opCgGYk8aG8/QlpnoZO7eeQJxKU7+t/JxY
UCRQNZXzh6WbTDLkRkP5u3vIA0qGqpGNkH9D7lGU8W9Iq9awkr3gtLls1HGuyGI+
zdYpLeC9JYYRPPZSG/Guy58NphuYRG3vCj6D8tvLqMzE3dYCIBwxobWESV26s40h
do3oqPTpmFYWJNJG4C1x0H3JfMW32X5ibrk8Hn6AFvHn4DYsdD4c24Ofol9IcIqf
nbgsYwrf5rdyiqgK5MUVXoFztNkPot6BSI+sU/ft3CcxX+0/cpSYiZ3M3QOk8BGt
J5Q7/57oBxcLrZrlEmE9PE+rmGDpw6F60DqZpGo5EwyzZmb4nKM=
=V/cr
-----END PGP SIGNATURE-----