[U-Boot] [linux-sunxi] Re: [PATCH v2 05/13] sunxi: add config for SPL at 0x20000 on H6

[Jagan Teki]

On Tue, Jul 24, 2018 at 2:06 PM, Icenowy Zheng <icenowy at aosc.io> wrote:
>
>
> 于 2018年7月24日 GMT+08:00 下午4:34:52, Maxime Ripard <maxime.ripard at bootlin.com> 写到:
>>On Sat, Jul 21, 2018 at 04:20:24PM +0800, Icenowy Zheng wrote:
>>> On the new Allwinner H6 SoC, the SRAM A2 address (SPL load address)
>>is
>>> at 0x20000, which is different with any old Allwinner SoCs.
>>>
>>> Add SPL position and size configuration for this.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy at aosc.io>
>>> Reviewed-by: Andre Przywara <andre.przywara at arm.com>
>>> ---
>>> Changes in v2:
>>> - Added Andre's Reviewed-by tag.
>>>
>>>  include/configs/sunxi-common.h | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/include/configs/sunxi-common.h
>>b/include/configs/sunxi-common.h
>>> index 1b5daa8928..4db770d69d 100644
>>> --- a/include/configs/sunxi-common.h
>>> +++ b/include/configs/sunxi-common.h
>>> @@ -199,6 +199,11 @@
>>>  #else
>>>  #define LOW_LEVEL_SRAM_STACK                0x00018000
>>>  #endif /* !CONFIG_ARM64 */
>>> +#elif CONFIG_SUNXI_SRAM_ADDRESS == 0x20000
>>> +#define CONFIG_SPL_TEXT_BASE                0x20060         /* sram start+header */
>>> +#define CONFIG_SPL_MAX_SIZE         0x7fa0          /* 32 KiB */
>>> +/* end of SRAM A2 on H6 for now */
>>> +#define LOW_LEVEL_SRAM_STACK                0x00118000
>>
>>Can't we move those options to Kconfig, and deal with those changes
>>there instead?
>
> It's possible, but not any cleaner.
>
> It will still be a hugh set of default xxx if xxx.

It's fine. we can do it. LOW_LEVEL_SRAM_STACK doesn't seem like CONFIG
item so moving them to kconfig and assugn to SPL_STACK would be
better.