[U-Boot] [U-Boot, v5] u-boot: remove driver lookup loop from env_save()

Tom Rini trini at konsulko.com
Mon Jul 30 20:01:42 UTC 2018


On Mon, Jul 23, 2018 at 10:01:07AM +0200, Nicholas Faustini wrote:

> When called with ENVOP_SAVE, env_get_location() only returns the
> gd->env_load_location variable without actually checking for
> the environment location and priority.
> 
> This behaviour causes env_save() to fall into an infinite loop when
> the low-level drv->save() call fails.
> 
> The env_save() function should not loop through the environment
> location list but it should save the environment into the location
> stored in gd->env_load_location by the last env_load() call.
> 
> Signed-off-by: Nicholas Faustini <nicholas.faustini at azcomtech.com>
> Reviewed-by: Simon Goldschmidt <sgoldschmidt at de.pepperl-fuchs.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180730/73340dad/attachment.sig>


More information about the U-Boot mailing list