[U-Boot] [U-Boot, 1/2] snapdragon: Add DRAM detection & FDT fixup

[Ramon Fried]

On Mon, Jul 30, 2018 at 2:29 PM Ramon Fried <ramon.fried at gmail.com> wrote:

> On July 30, 2018 2:18:17 PM GMT+03:00, Tom Rini <trini at konsulko.com>
> wrote:
> >On Sun, Jul 22, 2018 at 09:46:05PM +0300, Ramon Fried wrote:
> >
> >> Fixup the Linux FDT with the detection of onboard DRAM as
> >> provided by SBL (Secondary boot loader) by reading
> >> the shared-memory region.
> >>
> >> Signed-off-by: Ramon Fried <ramon.fried at gmail.com>
> >
> >This breaks 820c and adds a warning on 410c (this is with 2/2 applied
> >as well):
> >   aarch64:  +   dragonboard820c dragonboard410c
> >+(dragonboard820c,dragonboard410c)   ret = fdt_fixup_memory_banks(blob,
> >bank_start, bank_size, count);
> >+(dragonboard820c,dragonboard410c)         ^~~~~~~~~~~~~~~~~~~~~~
> >+(dragonboard820c,dragonboard410c)         msm_fixup_memory
> >+(dragonboard410c)   msm_fixup_memory(blob);
> >+(dragonboard410c)   ^~~~~~~~~~~~~~~~
> >+(dragonboard410c)   fdt_fixup_memory
> >w+(dragonboard820c,dragonboard410c) ../arch/arm/mach-snapdragon/dram.c:
> >In function 'msm_fixup_memory':
> >w+(dragonboard820c,dragonboard410c)
> >../arch/arm/mach-snapdragon/dram.c:91:8: warning: implicit declaration
> >of function 'fdt_fixup_memory_banks'; did you mean 'msm_fixup_memory'?
> >[-Wimplicit-function-declaration]
> >w+(dragonboard410c)
> >../board/qualcomm/dragonboard410c/dragonboard410c.c: In function
> >'ft_board_setup':
> >w+(dragonboard410c)
> >../board/qualcomm/dragonboard410c/dragonboard410c.c:183:2: warning:
> >implicit declaration of function 'msm_fixup_memory'; did you mean
> >'fdt_fixup_memory'? [-Wimplicit-function-declaration]
>
> Thanks Tom.
> Strange. I don't recall it introduced warning message. Will look into it
> in the evening.
>
> Well. you're right, sorry for the problem. resent the patches with the fix.
Thanks,
Ramon.


> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>