[U-Boot] [PATCH v2 1/8] armv8: ls1088a: fix sd boot config compile issue

York Sun york.sun at nxp.com
Tue Jul 31 20:32:14 UTC 2018


On 07/17/2018 08:03 PM, Yinbo Zhu wrote:
> This patch is to fix sd boot config compile issue for ls1088a.
> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu at nxp.com>
> ---
> Change in v2:
> 		Changed this patch's order
> 
>  include/mmc.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/mmc.h b/include/mmc.h
> index 534c317..66e69b7 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -604,7 +604,7 @@ struct mmc {
>  	u64 enh_user_start;
>  	u64 enh_user_size;
>  #endif
> -#if !CONFIG_IS_ENABLED(BLK)
> +#if CONFIG_IS_ENABLED(BLK)
>  	struct blk_desc block_dev;
>  #endif
>  	char op_cond_pending;	/* 1 if we are waiting on an op_cond command */
> 

NAK.

You can't simply reverse the logic. This code has been working for so
many platforms. Simply changing may fix your problem but definitely
breaks all others. Please find your root cause and fix properly.

York


More information about the U-Boot mailing list