[U-Boot] [PATCH] spi: cadence_qspi: Fix warning cast from pointer to integer of different size

Marek Vasut marex at denx.de
Fri Jun 1 09:55:10 UTC 2018


On 06/01/2018 10:52 AM, Ley Foon Tan wrote:
> Use "%p" to print cmdbuf.
> 
> Compilation warning as below:
> 
>   CC      spl/drivers/spi/cadence_qspi_apb.o
>   LD      spl/lib/built-in.o
> drivers/spi/cadence_qspi_apb.c: In function ‘cadence_qspi_apb_indirect_write_setup’:
> drivers/spi/cadence_qspi_apb.c:696:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>           cmdlen, (unsigned int)cmdbuf);
> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>

Acked-by: Marek Vasut <marex at denx.de>

> ---
> v2: Use "%p" instead of cast to ulong data type.
> ---
>  drivers/spi/cadence_qspi_apb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c
> index aa3a9ff..a8af352 100644
> --- a/drivers/spi/cadence_qspi_apb.c
> +++ b/drivers/spi/cadence_qspi_apb.c
> @@ -692,8 +692,8 @@ int cadence_qspi_apb_indirect_write_setup(struct cadence_spi_platdata *plat,
>  	unsigned int addr_bytes = cmdlen > 4 ? 4 : 3;
>  
>  	if (cmdlen < 4 || cmdbuf == NULL) {
> -		printf("QSPI: iInvalid input argument, len %d cmdbuf 0x%08x\n",
> -		       cmdlen, (unsigned int)cmdbuf);
> +		printf("QSPI: Invalid input argument, len %d cmdbuf %p\n",
> +		       cmdlen, cmdbuf);
>  		return -EINVAL;
>  	}
>  	/* Setup the indirect trigger address */
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list