[U-Boot] [PATCH] sunxi: use CONFIG_DEFAULT_FDT_FILE everywhere

Maxime Ripard maxime.ripard at bootlin.com
Fri Jun 1 11:05:23 UTC 2018


On Thu, May 31, 2018 at 05:59:16PM -0700, Martin Kelly wrote:
> Currently, sunxi-common.h ignores CONFIG_DEFAULT_FDT_FILE and assumes
> the kernel fdtfile and the u-boot devicetree names are the same.
> Although this is typically the case, sometimes you might want to
> customize one of these differently, so it's useful to allow them to be
> different.
> 
> Fix this to use only CONFIG_DEFAULT_FDT_FILE as other boards do, and set
> CONFIG_DEFAULT_FDT_FILE in board files to be the same as the current
> fdtfile= setting.
> 
> Signed-off-by: Martin Kelly <mkelly at xevo.com>

I'd really prefer not to do that. There's going to be a long trail of
defconfig that will be sent at pretty much the same time that are not
going to have it and that will go unnotice for some time.

And there's obviously the useless churn in all the defconfig that are
not in the case where it makes sense to override DEFAULT_FDT_FILE.

Why not create a Kconfig boolean that allows to select whether or not
you want DEFAULT_FDT_FILE to be DEFAULT_DEVICE_TREE + .dtb or a custom
value.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180601/62595c74/attachment-0001.sig>


More information about the U-Boot mailing list