[U-Boot] [RFC][DO NOT APPLY] binman: Switch to 'python-coverage'
Simon Glass
sjg at chromium.org
Fri Jun 1 14:27:03 UTC 2018
Hi Tom,
On 26 May 2018 at 11:06, Tom Rini <trini at konsulko.com> wrote:
> The most portable way to get access to coverage is to invoke it as
> 'python-coverage'.
>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> So, here's the set of problems I have. First, running 'pip install
> coverage' doesn't get me a 'coverage' binary, so I've just never made
> good use of 'make tests' and so never have these run. It also means
> they aren't strictly in travis-ci, so they're never run automatically.
> With this patch, make tests executes for me, and now fails noting that a
> lot of things don't have coverage. I'm honestly not sure what the best
> path forward here is.
> ---
> tools/binman/README | 3 +--
> tools/binman/binman.py | 4 ++--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
Reviewed-by: Simon Glass <sjg at chromium.org>
For me this patch works fine. The -T option works correctly.
Typing 'python-coverage html' produces this report:
https://pste.eu/p/NI7q.html
Note that your patch needs to update this line too:
print "Type 'coverage html' to get a report in htmlcov/index.html"
Can you send me the output you see?
Regards,
Simon
More information about the U-Boot
mailing list