[U-Boot] [PATCH] efi_loader: Fix warning in raw/cols query

[Alexander Graf]

> Am 03.06.2018 um 19:37 schrieb Heinrich Schuchardt <xypron.debian at gmx.de>:
> 
>> On 06/03/2018 03:52 PM, Alexander Graf wrote:
>> The code to determine rows / cols on the screen could potentially run
>> into a case where it doesn't know how big the screen is. In that case,
>> assume 80x25.
> 
> This patch may silence a compiler warning. But to me it is unclear on
> which path of the code we could end up actually using undefined values
> of cols or rows without the patch.
> 
> If we are copying cols and rows from vidconsole, this patch does not
> make a difference.
> 
> If we call query_console_serial() that routine either initializes rows
> and cols or returns -1 in which case we do not consume rows and cols.
> 
> Could you, please, either clearly state that this patch only serves to
> silence an invalid compiler warning or identify the path to the
> consumption of uninitialized values.

If the serial client on the other end replies with <esc>[t then the values of n are uninitialized. I have to admit that this patch doesn't help in that case either though.


Alex