[U-Boot] [PATCH 2/3] board: samsung: add missing line breaks for pr_err()

Seung-Woo Kim sw0312.kim at samsung.com
Mon Jun 4 07:03:05 UTC 2018


After the commit 9b643e312d52 ("treewide: replace with error() with
pr_err()"), there are some pr_err() with no line break. Add missing
line breaks.

Signed-off-by: Seung-Woo Kim <sw0312.kim at samsung.com>
---
 board/samsung/common/exynos5-dt.c |    2 +-
 board/samsung/common/misc.c       |    2 +-
 board/samsung/odroid/odroid.c     |   12 ++++++------
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c
index 9f6f654..8c3a9ea 100644
--- a/board/samsung/common/exynos5-dt.c
+++ b/board/samsung/common/exynos5-dt.c
@@ -164,7 +164,7 @@ int board_usb_init(int index, enum usb_init_type init)
 		samsung_get_base_usb3_phy();
 
 	if (!phy) {
-		pr_err("usb3 phy not supported");
+		pr_err("usb3 phy not supported\n");
 		return -ENODEV;
 	}
 
diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
index c9df7e6..05243fc 100644
--- a/board/samsung/common/misc.c
+++ b/board/samsung/common/misc.c
@@ -456,7 +456,7 @@ void draw_logo(void)
 
 	addr = panel_info.logo_addr;
 	if (!addr) {
-		pr_err("There is no logo data.");
+		pr_err("There is no logo data.\n");
 		return;
 	}
 
diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
index 1c2bd01..552333f 100644
--- a/board/samsung/odroid/odroid.c
+++ b/board/samsung/odroid/odroid.c
@@ -428,7 +428,7 @@ int exynos_power_init(void)
 	};
 
 	if (regulator_list_autoset(mmc_regulators, NULL, true))
-		pr_err("Unable to init all mmc regulators");
+		pr_err("Unable to init all mmc regulators\n");
 
 	return 0;
 }
@@ -441,7 +441,7 @@ static int s5pc210_phy_control(int on)
 
 	ret = regulator_get_by_platname("VDD_UOTG_3.0V", &dev);
 	if (ret) {
-		pr_err("Regulator get error: %d", ret);
+		pr_err("Regulator get error: %d\n", ret);
 		return ret;
 	}
 
@@ -486,25 +486,25 @@ int board_usb_init(int index, enum usb_init_type init)
 
 	ret = regulator_get_by_platname("VCC_P3V3_2.85V", &dev);
 	if (ret) {
-		pr_err("Regulator get error: %d", ret);
+		pr_err("Regulator get error: %d\n", ret);
 		return ret;
 	}
 
 	ret = regulator_set_enable(dev, true);
 	if (ret) {
-		pr_err("Regulator %s enable setting error: %d", dev->name, ret);
+		pr_err("Regulator %s enable setting error: %d\n", dev->name, ret);
 		return ret;
 	}
 
 	ret = regulator_set_value(dev, 750000);
 	if (ret) {
-		pr_err("Regulator %s value setting error: %d", dev->name, ret);
+		pr_err("Regulator %s value setting error: %d\n", dev->name, ret);
 		return ret;
 	}
 
 	ret = regulator_set_value(dev, 3300000);
 	if (ret) {
-		pr_err("Regulator %s value setting error: %d", dev->name, ret);
+		pr_err("Regulator %s value setting error: %d\n", dev->name, ret);
 		return ret;
 	}
 #endif
-- 
1.7.9.5



More information about the U-Boot mailing list