[U-Boot] Unclear patch origin ?

Wolfgang Denk wd at denx.de
Mon Jun 4 16:03:44 UTC 2018


Dear Tom,

I wonder where 

	commit b5351a439088dfffd83bfaac81f604344ee2e3bd
	Author: Tom Rini <trini at konsulko.com>
	Date:   Sun Jun 3 16:10:22 2018 -0400

	    SPDX: Fixup tags from latest EFI PR
	    
	    Signed-off-by: Tom Rini <trini at konsulko.com>

(and maybe more) is/are coming from.  I cannot see any trace of this
on the U-Boot mailing list.  Which means, the patch was probably
checked in without any review taking place?  What is the process
here?


What I really wonder about is this part of the commit:

--- a/arch/sandbox/include/asm/setjmp.h
+++ b/arch/sandbox/include/asm/setjmp.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * (C) 2018 Google, Inc
  * Written by Simon Glass <sjg at chromium.org>


i. e. you change the C++ comment style into classic C style - which
we discussed at length, and you told me that was deprecated at this
place?

I can't understand what is going on here...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One thing they don't tell you about doing  experimental  physics  is
that sometimes you must work under adverse conditions... like a state
of sheer terror."                                    - W. K. Hartmann


More information about the U-Boot mailing list