[U-Boot] [PATCH 1/2] ARM: image: Add option for ignoring ep bit 3

[Marek Vasut]

On 06/04/2018 08:16 PM, Tom Rini wrote:
> On Mon, Jun 04, 2018 at 08:05:55PM +0200, Marek Vasut wrote:
>> On 06/04/2018 08:01 PM, Tom Rini wrote:
>>> On Mon, Jun 04, 2018 at 06:27:32PM +0200, Marek Vasut wrote:
>>>> On 06/04/2018 02:59 AM, Tom Rini wrote:
>>>>> On Sat, Jun 02, 2018 at 11:36:00PM +0200, Marek Vasut wrote:
>>>>>
>>>>>> Add option to the booti_setup() which indicates to it that the caller
>>>>>> requires the image to be relocated to the beginning of the RAM and
>>>>>> that the information whether the image can be located anywhere in RAM
>>>>>> at 2 MiB aligned boundary or not is to be ignored. This is useful ie.
>>>>>> in case the Image is wrapped in another envelope, ie. fitImage and not
>>>>>> relocating it but moving it would corrupt the envelope.
>>>>>>
>>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>>>>>> Cc: Bin Chen <bin.chen at linaro.org>
>>>>>> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>>>>>> Cc: Tom Rini <trini at konsulko.com>
>>>>>> ---
>>>>>>  arch/arm/lib/image.c | 5 +++--
>>>>>>  cmd/booti.c          | 2 +-
>>>>>>  include/image.h      | 4 +++-
>>>>>>  3 files changed, 7 insertions(+), 4 deletions(-)
>>>>>>
>>>>>> diff --git a/arch/arm/lib/image.c b/arch/arm/lib/image.c
>>>>>> index 1a04e2b875..08c7b8a54f 100644
>>>>>> --- a/arch/arm/lib/image.c
>>>>>> +++ b/arch/arm/lib/image.c
>>>>>> @@ -26,7 +26,8 @@ struct Image_header {
>>>>>>  	uint32_t	res5;
>>>>>>  };
>>>>>>  
>>>>>> -int booti_setup(ulong image, ulong *relocated_addr, ulong *size)
>>>>>> +int booti_setup(ulong image, ulong *relocated_addr, ulong *size,
>>>>>> +		int ignore_ep)
>>>>>
>>>>> This should be 'bool' not 'int'.
>>>>
>>>> Which blows up a couple of things, so to keep this patch small, it's int.
>>>
>>> Can you elaborate please?  Thanks!
>>
>> Well, just try compiling it with bool, it'll choke on bool being
>> undeclared on some boards which include the header.
> 
> Which boards?  Or rather, I bet a file or two in tools/ needs
> <stdbool.h> ?  That said, I'm not even 100% sure on that as
> tools/kwbimage.c uses 'bool' and doesn't include stdbool.h.
> 
> Regardless, please fix whatever needs fixing so that we can continue to
> use 'bool' for true/false and not int.  Thanks!

This feels like an overkill to me ? But I dont think the header should
include stdbool itself either.

-- 
Best regards,
Marek Vasut