[U-Boot] [PATCHv2] block: Have BLOCK_CACHE default to y in some cases

Tom Rini trini at konsulko.com
Fri Jun 8 19:15:42 UTC 2018


On Fri, Jun 08, 2018 at 10:30:36AM -0500, Adam Ford wrote:
> On Tue, May 22, 2018 at 11:24 AM Tom Rini <trini at konsulko.com> wrote:
> >
> > When dealing with filesystems that come from block devices we can get a
> > noticeable performance gain in some use cases from having the block
> > cache enabled.  The code paths are valid in other cases when we have BLK
> > set and may provide wins in raw reads in some use cases, so have this be
> > default when BLK is enabled.
> >
> Tony,
> 
> This breaks the AM3517 EVM. It appears to cause issues in MLO which
> may not have enough RAM to cache, but I can fix it by disabling
> BLOCK_CACHE.
> I can submit a patch to disable it on the AM3517, but I am wondering
> if something can/should be done to disable it or optionally disable it
> in SPL so it's still
> available in U-Boot.  I can confirm that when disabled in SPL only, it works.
> 
> Any opinions on this?

So, we had talked before about bumping SYS_MALLOC_F_LEN to 0x2000 for
ARCH_OMAP2PLUS, but I see am3517 is already doing that.  Can you see if
there's enough room to go to say 0x4000 and it works?  Otherwise, we
need to (and I was worried we might) need to add SPL_BLOCK_CACHE and
have that default off.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180608/857880ed/attachment.sig>


More information about the U-Boot mailing list