[U-Boot] [PATCH v3 2/2] patman: add test for SPDX license

Simon Glass sjg at chromium.org
Fri Jun 8 21:59:09 UTC 2018


On 7 June 2018 at 00:45, Chris Packham <judge.packham at gmail.com> wrote:
> Add a test to exercise the check for a valid SPDX license.
>
> Signed-off-by: Chris Packham <judge.packham at gmail.com>
> ---
> This is dependent on http://patchwork.ozlabs.org/patch/914202/
>
> I also seem to get a bunch of doctest failures due to unicode strings, e.g.
>
>   File "tools/patman/settings.py", line 78, in settings._ProjectConfigParser
>   Failed example:
>       sorted(config.items("settings"))
>   Expected:
>       [('am_hero', 'True')]
>   Got:
>       [('am_hero', u'True')
>
> I haven't attempted to fix these as I suspect they might be python
> version (2.7.12 for me) and/or locale dependent.

That is a bit odd since I would expect those lists to be the same.
Normally you can compare uincode and strings without any trouble.

>
> Changes in v3:
> - new
>
> Changes in v2: None
>
>  tools/patman/test.py | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list