[U-Boot] [PATCH 2/4] soc: qualcomm: Add Shared Memory Manager driver

Heinrich Schuchardt xypron.glpk at gmx.de
Sat Jun 9 10:12:38 UTC 2018


On 06/09/2018 01:06 PM, Ramon Fried wrote:
> The Shared Memory Manager driver implements an interface for allocating
> and accessing items in the memory area shared among all of the
> processors in a Qualcomm platform.
> 
> Adapted from the Linux driver (4.17)

Please, run scripts/checkpatch on this patch an fix all errors and
warnings, e.g.

WARNING: line over 80 characters
#1064: FILE: drivers/soc/qualcomm/smem.c:846:
+       smem->regions[i].virt_base = devm_ioremap(dev, r.start,
fdt_resource_size(&r));

CHECK: Alignment should match open parenthesis
#1098: FILE: drivers/soc/qualcomm/smem.c:880:
+       if (num_regions > 1 && (ret = qcom_smem_map_memory(smem, dev,
+                                       "qcom,rpm-msg-ram", 1)))

Do not use DOS line endings.

Best regards

Heinrich Schuchardt


More information about the U-Boot mailing list