[U-Boot] [PATCH 2/4] soc: qualcomm: Add Shared Memory Manager driver

Heinrich Schuchardt xypron.glpk at gmx.de
Sat Jun 9 10:24:44 UTC 2018


On 06/09/2018 01:06 PM, Ramon Fried wrote:
> The Shared Memory Manager driver implements an interface for allocating
> and accessing items in the memory area shared among all of the
> processors in a Qualcomm platform.
> 
> Adapted from the Linux driver (4.17)
> 
> Changes from the original Linux driver:
> * Removed HW spinlock mechanism, which is irrelevant
> in U-boot particualar use case, which is just reading from the smem.
> * adaptaion from Linux driver model to U-boot's.
> 
> Cc: Bjorn Andersson <bjorn.andersson at linaro.org>
> Signed-off-by: Ramon Fried <ramon.fried at gmail.com>
> ---
> 

<snip />

> +/* Pointer to the one and only smem handle */
> +static struct qcom_smem *__smem;
> +
> +static int qcom_smem_alloc_private(struct qcom_smem *smem,
> +				   struct smem_partition_header *phdr,
> +				   unsigned item,
> +				   size_t size)
> +{

<snip />

> +	 */
> +	dmb();
> +	le32_add_cpu(&phdr->offset_free_uncached, alloc_size);


drivers/soc/qualcomm/smem.c: In function ‘qcom_smem_alloc_private’:
drivers/soc/qualcomm/smem.c:391:2: warning: implicit declaration of
function ‘le32_add_cpu’ [-Wimplicit-function-declaration]
  le32_add_cpu(&phdr->offset_free_uncached, alloc_size);

Please, add the missing definition to
./include/linux/byteorder/generic.h
or reference the prerequisite patch in the commit message.

Best regards

Heinrich



More information about the U-Boot mailing list