[U-Boot] [PATCH 01/18] x86: doc: Fix reference to EFI doc in U-Boot

[Heinrich Schuchardt]

On 06/10/2018 04:01 PM, Bin Meng wrote:
> Hi Heinrich,
> 
> On Sun, Jun 10, 2018 at 9:39 PM, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>> On 06/10/2018 03:25 PM, Bin Meng wrote:
>>> Since commit f3b5056c4e72 ("efi_loader: split README.efi into two
>>> separate documents"), the original README.efi was renamed to
>>> README.u-boot_on_efi, but x86 doc still refers to the old one.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>> ---
>>>
>>>  doc/README.x86 | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/doc/README.x86 b/doc/README.x86
>>> index 78664c3..865a965 100644
>>> --- a/doc/README.x86
>>> +++ b/doc/README.x86
>>> @@ -1139,7 +1139,7 @@ application, with CONFIG_EFI_APP. The CONFIG_EFI_LOADER option, where U-Booot
>>>  provides an EFI environment to the kernel (i.e. replaces UEFI completely but
>>>  provides the same EFI run-time services) is not currently supported on x86.
>>>
>>> -See README.efi for details of EFI support in U-Boot.
>>> +See  for details of EFI support in U-Boot.
>>
>> Thanks for updating the references.
>>
>> The chapter "EFI Support" refers both to running U-Boot as an EFI
>> payload as well as using U-Boot as an EFI platform. So both
>> doc/README.u-boot_on_efi and doc/README.uefi should be referenced.
>>
> 
> OK, will do in v2. One question: the doc says: CONFIG_EFI_LOADER
> option is not currently supported on x86. Is this still the case, or
> outdated? (I haven't tried the EFI loader on x86 or ARM yet)

qemu-x86_defconfig has CONFIG_EFI_LOADER enabled by default.
bootefi selftest is successful.

But loading Linux fails by trying to use video memory as normal memory.

E.g. memory reservations according to e820 table are missing.

Patch https://patchwork.ozlabs.org/patch/860400/ is not sufficient to
resolve the issue.

I lack the knowledge which memory regions have to be reserved on the
platform.

Best regards

Heinrich

> 
>> But I would prefer if you could also move the sentences concerning EFI
>> that has spilled over into "64-bit Support" into the "EFI Support" chapter.
>>
> 
> Sure.
> 
> Regards,
> Bin
>