[U-Boot] [PATCH] arm: mvebu: Add Helios4 Armada 38x initial support

[Stefan Roese]

Hi Dennis,

On 06.06.2018 15:25, dgilmore at redhat.com wrote:
> From: Dennis Gilmore <dennis at ausil.us>
> 
> The helios4 is built on the SolidRun Armada 38x SOM.
> The port os based on the ClearFog board, using information from
> https://github.com/helios-4/u-boot-marvell as well as dtb input
> from https://github.com/helios-4/linux-marvell
> 
> Signed-off-by: Dennis Gilmore <dennis at ausil.us>
> Signed-off-by: Dennis Gilmore <dgilmore at redhat.com>
> ---
> changes since RFC
> add armada-38x-solidrun-microsom.dtsi minus buffer-memory nodes from linux kernel
> fix up maintainers file
> use correct switch in README file
> add SPDX header to kwbimage.cfg and dts file
> Port to DM_I2C
> 
> Changes since V1
> moved to kobol namespace at the request of the board supplier
> remove gpio resets they are clearfog specific
> set maintainer to myself and update copyrights
> remove unused config options

Before pulling this patch into mainline, I ran the checkpatch
--git test as requested by Tom. This reveals some mostly minor
issues:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

WARNING: line over 80 characters
#245: FILE: arch/arm/dts/armada-388-helios4.dts:190:
+                                               line-name = "usb-overcurrent-status";

CHECK: Prefer using the BIT macro
#617: FILE: board/kobol/helios4/helios4.c:22:
+#define ETH_PHY_CTRL_POWER_DOWN_MASK   (1 << ETH_PHY_CTRL_POWER_DOWN_BIT)

WARNING: Missing a blank line after declarations
#730: FILE: board/kobol/helios4/helios4.c:135:
+               int ret;
+               ret = i2c_get_chip_for_busnum(0, io_exp[i].addr, 1, &dev);

ERROR: code indent should use tabs where possible
#890: FILE: include/configs/helios4.h:44:
+                                         CONFIG_SYS_SCSI_MAX_LUN)$

WARNING: please, no spaces at the start of a line
#890: FILE: include/configs/helios4.h:44:
+                                         CONFIG_SYS_SCSI_MAX_LUN)$

CHECK: Macro argument reuse 'func' - possible side-effects?
#987: FILE: include/configs/helios4.h:141:
+#define BOOT_TARGET_DEVICES(func) \
+       BOOT_TARGET_DEVICES_MMC(func) \
+       BOOT_TARGET_DEVICES_USB(func) \
+       BOOT_TARGET_DEVICES_SATA(func) \
+       func(PXE, pxe, na) \
+       func(DHCP, dhcp, na)

total: 1 errors, 4 warnings, 2 checks, 914 lines checked

Could you please check and fix most of these issues (BIT macro, missing
blank line, code indentation and space at start of line)?

Thanks,
Stefan