[U-Boot] [RESEND][PATCH 5/9] clk: Add Actions Semi OWL clock support

[Simon Glass]

Hi,

On 11 June 2018 at 09:48, Manivannan Sadhasivam
<manivannan.sadhasivam at linaro.org> wrote:
> This commit adds Actions Semi OWL family base clock and S900 SoC specific
> clock support. For S900 peripheral clock support, only UART clock has been
> added for now.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
> ---
>  arch/arm/include/asm/arch-owl/clk_owl.h   |  61 +++++++++++++
>  arch/arm/include/asm/arch-owl/regs_s900.h |  64 +++++++++++++
>  arch/arm/mach-owl/Kconfig                 |   2 +-
>  drivers/clk/Kconfig                       |   1 +
>  drivers/clk/Makefile                      |   1 +
>  drivers/clk/owl/Kconfig                   |  12 +++
>  drivers/clk/owl/Makefile                  |   4 +
>  drivers/clk/owl/clk_owl.c                 |  60 +++++++++++++
>  drivers/clk/owl/clk_s900.c                | 104 ++++++++++++++++++++++
>  9 files changed, 308 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/include/asm/arch-owl/clk_owl.h
>  create mode 100644 arch/arm/include/asm/arch-owl/regs_s900.h
>  create mode 100644 drivers/clk/owl/Kconfig
>  create mode 100644 drivers/clk/owl/Makefile
>  create mode 100644 drivers/clk/owl/clk_owl.c
>  create mode 100644 drivers/clk/owl/clk_s900.c

This doesn't look quite right to me. It looks like you should put all
the code in clk_s900.c and delete clk_owl.c.

Regards,
Simon