[U-Boot] [PATCH v2 2/3] rk3288: Disable JTAG function from sdmmc0 IO

Carlo Caione carlo at endlessm.com
Mon Jun 11 17:08:03 UTC 2018


On Mon, 2018-06-11 at 10:41 +0200, Dr. Philipp Tomsich wrote:
> > On 11 Jun 2018, at 10:08, Carlo Caione <carlo at caione.org> wrote:

/cut
> > +#define GRF_SOC_CON0 0xff770244
> > #define GRF_SOC_CON2 0xff77024c
> 
> Could you convert these to ‘const uintptr_t GRF_SOC_CON0 = …’ ?
> The compiler will generate the same code for a const as if it’s a
> define, but we’ll
> have full type-safety.

Yeah, no problem. But if this is ok with you in v3 I'm going to leave
this patch as is and adding one more patch to convert both the lines at
the same time.

Thanks.


More information about the U-Boot mailing list