[U-Boot] [PATCH 6/8] rsa: Fix missing memory leak on error in fdt_add_bignum()

[Simon Glass]

Hi Heinrich,

On 9 June 2018 at 13:50, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> On 06/09/2018 08:22 PM, Simon Glass wrote:
>> Thsi function can fail without freeing all its memory. Fix it.
>>
>> Reported-by: Coverity (CID: 131217)
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  lib/rsa/rsa-sign.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c
>> index d2788bf79a..2a09d2b19e 100644
>> --- a/lib/rsa/rsa-sign.c
>> +++ b/lib/rsa/rsa-sign.c
>> @@ -667,15 +667,13 @@ static int fdt_add_bignum(void *blob, int noffset, const char *prop_name,
>>        * might fail several times
>
> Please, fix the memory leaks above this line too.

Coverity does not seem to detect these as memory leaks.

I've added a comment explaining why I don't think it makes sense to 'fix' these.

Regards,
Simon