[U-Boot] [PATCH] gpio: zynq: Do not check unsigned type that is >= 0

Michal Simek michal.simek at xilinx.com
Wed Jun 13 07:07:14 UTC 2018


There is no reason to check that unsigned type that is >= 0.

Signed-off-by: Michal Simek <michal.simek at xilinx.com>
---

 drivers/gpio/zynq_gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/zynq_gpio.c b/drivers/gpio/zynq_gpio.c
index 4cb75a862780..804ddbd4983b 100644
--- a/drivers/gpio/zynq_gpio.c
+++ b/drivers/gpio/zynq_gpio.c
@@ -189,7 +189,7 @@ static int gpio_is_valid(unsigned gpio, struct udevice *dev)
 {
 	struct zynq_gpio_privdata *priv = dev_get_priv(dev);
 
-	return (gpio >= 0) && (gpio < priv->p_data->ngpio);
+	return gpio < priv->p_data->ngpio;
 }
 
 static int check_gpio(unsigned gpio, struct udevice *dev)
-- 
1.9.1



More information about the U-Boot mailing list