[U-Boot] [U-Boot, v4, 2/2] test/py: add test for whitelist of variables while importing environment

[Tom Rini]

On Wed, Jun 13, 2018 at 08:53:12PM +0200, Quentin Schulz wrote:
> Hi Tom,
> 
> On Wed, Jun 13, 2018 at 11:43:32AM -0400, Tom Rini wrote:
> > On Mon, Jun 04, 2018 at 11:47:30AM +0200, Quentin Schulz wrote:
> > 
> > > This tests that the importing of an environment with a specified
> > > whitelist works as intended.
> > > 
> > > If there are variables passed as parameter to the env import command,
> > >    those only should be imported in the current environment.
> > > 
> > > For each variable passed as parameter, if
> > >  - foo is bar in current env and bar2 in exported env, after importing
> > >  exported env, foo shall be bar2,
> > >  - foo does not exist in current env and foo is bar2 in exported env,
> > >  after importing exported env, foo shall be bar2,
> > >  - foo is bar in current env and does not exist in exported env (but is
> > >  passed as parameter), after importing exported env, foo shall be empty,
> > > 
> > > Any variable not passed as parameter should be left untouched.
> > > 
> > > Two other tests are made to test that size cannot be '-' if the checksum
> > > protection is enabled.
> > > 
> > > Signed-off-by: Quentin Schulz <quentin.schulz at bootlin.com>
> > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > > Reviewed-by: Stephen Warren <swarren at nvidia.com>
> > 
> > This seems to not be working?
> > 
> > https://travis-ci.org/trini/u-boot/jobs/391504525
> > 
> 
> I just rebased on top of v2018.07-rc1, ran
> make mrproper
> ./test/py/test.py --bd sandbox --build
> 
> and the tests run fine until one error in some tests *after* the env
> test suite has passed. See log:
> http://code.bulix.org/iojwnp-358559
> 
> It's dirty because I had to remove NO_SDL to make sandbox to compile
> $ git diff
> diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
> index 1a49d1dab5..a76fc384c2 100644
> --- a/include/configs/sandbox.h
> +++ b/include/configs/sandbox.h
> @@ -74,10 +74,6 @@
>  #define CONFIG_BOOTP_SERVERIP
>  #define CONFIG_IP_DEFRAG
>  
> -#ifndef SANDBOX_NO_SDL
> -#define CONFIG_SANDBOX_SDL
> -#endif
> -
>  /* LCD and keyboard require SDL support */
>  #ifdef CONFIG_SANDBOX_SDL
>  #define LCD_BPP                        LCD_COLOR16
> 
> Can I have more info on how to reproduce this error please?

So, sandbox is clean and doesn't fail.  Looking at the job itself,
https://travis-ci.org/trini/u-boot/builds/391504460, in addition to
failing on xtensa, it fails on integratorcp_cm926ejs, qemu-x86,
qemu-ppce500 and zynq_zc702.  Of those, qemu-x86 is probably the easiest
to reproduce locally for you.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180613/59ef2058/attachment.sig>