[U-Boot] [PATCH 4/5] serial: zynq: Check priv pointer get via dev_get_priv()

Simon Glass sjg at chromium.org
Thu Jun 14 12:58:33 UTC 2018


Hi,

On 14 June 2018 at 03:32, Michal Simek <michal.simek at xilinx.com> wrote:
> Make sure that functions are working with proper strcture.
>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
>
> Reported by: Coverity (local)
>
> ---
>  drivers/serial/serial_zynq.c | 27 ++++++++++++++++++++++++---
>  1 file changed, 24 insertions(+), 3 deletions(-)

But priv cannot be NULL if the device has been probed. So this check
is confusing at best.

If this is from coverity, perhaps you can find a way to mask it?

Regards,
Simon


More information about the U-Boot mailing list