[U-Boot] [PATCH 10/11] efi_loader: Pass virtual address to fs_read()

Simon Glass sjg at chromium.org
Thu Jun 14 16:55:38 UTC 2018


Hi Alex,

On 14 June 2018 at 10:33, Alexander Graf <agraf at suse.de> wrote:
> The fs_read() function wants to get a virtual (u-boot address space
> in sandbox) address rather than a physical (host address space in
> sandbox) one.
>

The terminology is wrong here. It is not about virtual and physical
addresses - that's an MMU concept.

It's about sandbox using a special memory buffer to emulate U-Boot
memory access.

The code is correct but the comment and commit message will cause
great confusion, so please fix.

It is document in a few READMEs, but perhaps I should add some
comments to mapmem.h ?

Regards,
Simon


More information about the U-Boot mailing list