[U-Boot] [PATCH 04/12] Net: phy: ti: Fix fifo_depth register write

[Trent Piepho]

On Thu, 2018-06-14 at 10:53 +0000, u-boot-request at lists.denx.de wrote:
> Message: 52
> Date: Thu, 14 Jun 2018 11:48:48 +0200
> From: Janine Hagemann <j.hagemann at phytec.de>
> To: albert.u.boot at aribaud.net, sjg at chromium.org,
> 	philipp.tomsich at theobroma-systems.com, w.egorov at phytec.de,
> 	joe.hershberger at ni.com, u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH 04/12] Net: phy: ti: Fix fifo_depth register
> 	write
> Message-ID: <1528969736-44037-4-git-send-email-j.hagemann at phytec.de>
> 
> The register was not read before the writing, so the
> previous value was overwritten.
> 
> @@ -233,9 +235,14 @@ static int dp83867_config(struct phy_device *phydev)
>  		  val | DP83867_SW_RESTART);
>  
>  	if (phy_interface_is_rgmii(phydev)) {
> +		val = phy_read(phydev, MDIO_DEVAD_NONE, MII_DP83867_PHYCTRL);
> +		if (val < 0)
> +			return val;
> +		val &= ~DP83867_PHYCR_FIFO_DEPTH_MASK;
> +		val |= (dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT);
>  		ret = phy_write(phydev, MDIO_DEVAD_NONE, MII_DP83867_PHYCTRL,
> -			(DP83867_MDI_CROSSOVER_AUTO << DP83867_MDI_CROSSOVER) |
> -			(dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT));
> +				val);
> +
>  		if (ret)
>  			goto err_out;
>  	} else if (phy_interface_is_sgmii(phydev)) {

If any of the bits that prevent the phy from working are set, like
DEEP_POWER_DOWN_EN, POWER_SAVE_MODE, and so on, they won't be reset
anymore.  I.e., put phy in power save mode, reboot, phy doesn't work
anymore.  I think the code here is suppose to be configuring the phy,
rather than changing a configuration that was done elsewhere.