[U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data

Jagan Teki jagannadh.teki at gmail.com
Mon Jun 18 06:15:23 UTC 2018


On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut <marex at denx.de> wrote:
> On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote:
>> ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be
>> the first member in private data struct.
>>
>> Fixes 831cc98b1 ("usb: sunxi: Simplify ccm reg base code")
>>
>> Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>
>
> Sigh, I really wonder how (or if at all!) the original series was
> tested. And then I get flak for scrutinizing patches, right ...

APAIK, I did basic sanity with possible tests.

But one thing for sure is, you should have to wait for sometime to
apply this patch. Applying fast (that to during weekend) making
reviewers or maintainers not giving enough room to work.

Jagan.


More information about the U-Boot mailing list