[U-Boot] [PATCH v8 19/30] efi: Relocate FDT to 127MB instead of 128MB

[Alexander Graf]

On 06/18/2018 04:08 PM, Simon Glass wrote:
> Sandbox only has 128MB of memory so we cannot relocate the device tree up
> to start at 128MB. Use 127MB instead, which should be safe.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>

We should just drop into the fallback case if allocation fails, no?


Alex

> ---
>
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>   cmd/bootefi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/bootefi.c b/cmd/bootefi.c
> index 3fa4f181ba..d2458e2397 100644
> --- a/cmd/bootefi.c
> +++ b/cmd/bootefi.c
> @@ -141,8 +141,8 @@ static void *copy_fdt(void *fdt)
>   	fdt_size = ALIGN(fdt_size + 4096, EFI_PAGE_SIZE);
>   	fdt_pages = fdt_size >> EFI_PAGE_SHIFT;
>   
> -	/* Safe fdt location is at 128MB */
> -	new_fdt_addr = fdt_ram_start + (128 * 1024 * 1024) + fdt_size;
> +	/* Safe fdt location is at 127MB */
> +	new_fdt_addr = fdt_ram_start + (127 * 1024 * 1024) + fdt_size;
>   	if (efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
>   			       EFI_RUNTIME_SERVICES_DATA, fdt_pages,
>   			       &new_fdt_addr) != EFI_SUCCESS) {