[U-Boot] [PATCH] efi_loader: Fix GOP 32bpp exposure

Peter Robinson pbrobinson at gmail.com
Tue Jun 19 15:46:50 UTC 2018


On Tue, Jun 19, 2018 at 12:47 PM, Alexander Graf <agraf at suse.de> wrote:
> We store pixels as BGRA in memory, as can be seen from struct efi_gop_pixel.
> So we need to expose the same format to UEFI payloads to actually have them
> use the correct colors.
>
> Reported-by: Fabian Vogt <fvogt at suse.com>
> Signed-off-by: Alexander Graf <agraf at suse.de>
Tested-by: Peter Robinson <pbrobinson at gmail.com>

Fixes the blue penguin feet on efi consoles for me on the RPi and Pine64.

> ---
>  lib/efi_loader/efi_gop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
> index 1afe8418e1..3a36bbcbfa 100644
> --- a/lib/efi_loader/efi_gop.c
> +++ b/lib/efi_loader/efi_gop.c
> @@ -472,7 +472,7 @@ efi_status_t efi_gop_register(void)
>         gopobj->info.version = 0;
>         gopobj->info.width = col;
>         gopobj->info.height = row;
> -       gopobj->info.pixel_format = EFI_GOT_RGBA8;
> +       gopobj->info.pixel_format = EFI_GOT_BGRA8;
>         gopobj->info.pixels_per_scanline = col;
>
>         gopobj->bpix = bpix;
> --
> 2.12.3
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot


More information about the U-Boot mailing list