[U-Boot] [PATCH v3 2/6] soc: qualcomm: Add Shared Memory Manager driver

[Simon Glass]

On 26 June 2018 at 04:20, Ramon Fried <ramon.fried at gmail.com> wrote:
> The Shared Memory Manager driver implements an interface for allocating
> and accessing items in the memory area shared among all of the
> processors in a Qualcomm platform.
>
> Adapted from the Linux driver (4.17)
>
> Changes from the original Linux driver:
> * Removed HW spinlock mechanism, which is irrelevant
> in U-boot particualar use case, which is just reading from the smem.
> * Adapted from Linux driver model to U-Boot's.
>
> Cc: Bjorn Andersson <bjorn.andersson at linaro.org>
> Signed-off-by: Ramon Fried <ramon.fried at gmail.com>
>
> ---
>
> Changes in v3:
> - Removed license, SPDX is enough.
> - Text and grammar fixes.
>
> Changes in v2:
> - Applied checkpatch fixes (also sent these to Linux upstream)
> - Changed UCLASS_SOC to UCLASS_SMEM
> - Removed function exports and registered functionality through .ops
>
>  MAINTAINERS             |   1 +
>  arch/arm/Kconfig        |   2 +
>  drivers/Kconfig         |   2 +
>  drivers/smem/Kconfig    |  13 +
>  drivers/smem/Makefile   |   1 +
>  drivers/smem/msm_smem.c | 932 ++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 951 insertions(+)
>  create mode 100644 drivers/smem/msm_smem.c

Reviewed-by: Simon Glass <sjg at chromium.org>

One thing I just noticed is that you are using fdt_ functions. You
should use livetree functions like dev_read_... and ofnode_...

Regards,
Simon