[U-Boot] [PATCH RESEND 0/4] Add CONFIG_SPL_NAND_IDENT

Stefano Babic sbabic at denx.de
Wed Jun 27 10:25:35 UTC 2018


Hi Jörg,

On 27/06/2018 11:51, Jörg Krause wrote:
> Hi Stefano,
> 
> On Wed, 2018-06-27 at 09:43 +0200, Stefano Babic wrote:
>> Hi Jörg,
>>
>> On 26/06/2018 11:33, Jörg Krause wrote:
>>> Hi,
>>>
>>> this patch series propably felt off the radar?
>>>
>>
>> I guess yes, but I doubt we can apply the series again. I guess you
>> should at least rebase it.
> 
> No problem!
> 
> I've applied the series without any conflicts on the master branch.
> Looks like nothing has changed in the mxs nand driver...
> 

There are some changes - I have applied Stefan's patches according to
the discussion with Tom:

https://patchwork.ozlabs.org/patch/897270/


But I have applied your patches on top of my u-boot-imx (with Stefan's),
no conflict at all. I guess it is ok if I merged yours into u-boot-imx
as I did for Stefan's.

Best regards,
Stefano Babic

> Best regards,
> Jörg Krause
> 
>> Regards,
>> Stefano
>>
>>> Best regards,
>>> Jörg Krause
>>>
>>> On Sun, 2018-01-14 at 19:26 +0100, Jörg Krause wrote:
>>>> RESEND because adding U-Boot NAND maintainer (Scott Wood) on Cc.
>>>>
>>>> When adding SPL support to a custom i.MX6ULL board with Toshiba
>>>> TC58NVG0S3 NAND chip the MXS NAND SPL loader failed with "Failed
>>>> to
>>>> identify". This reason is that the SPL MXS NAND driver only
>>>> supports
>>>> ONFi-compliant NAND chips and the mentioned Toshiba NAND chip is
>>>> non-ONFi.
>>>>
>>>> This patch set makes `nand_get_flash_type()` from `nand_base.c`
>>>> public,
>>>> so it can be used by any SPL NAND driver, introduced a new config
>>>> option
>>>> `CONFIG_SPL_NAND_IDENT` to enable the lookup for supported NAND
>>>> chips
>>>> in
>>>> the chip ID list. Finally, the MXS NAND SPL driver is refactored
>>>> so
>>>> that
>>>> the original ONFi-only identification routine is enabled by
>>>> default.
>>>> For
>>>> non-ONFi NAND chips the newly introduced config option can be
>>>> used.
>>>>
>>>> In my setup the binary size of `u-boot-spl.bin` is increased by
>>>> about
>>>> 13 kB when `CONFIG_SPL_NAND_IDENT` is enabled. As the i.MX6, as
>>>> well
>>>> as
>>>> the i.MX28, both have an OCRAM of 128 kB the increase in the
>>>> binary
>>>> size
>>>> is reasonable.
>>>>
>>>> Jörg Krause (4):
>>>>   mtd: nand: export nand_get_flash_type function
>>>>   spl, nand: add option CONFIG_SPL_NAND_IDENT to lookup for
>>>> supported
>>>>     NAND chips
>>>>   mtd: nand: mxs_nand_spl: refactor mxs_flash_ident
>>>>   mtd: nand: mxs_nand_spl: add mxs_flash_full_ident
>>>>
>>>>  README                          |  4 ++++
>>>>  drivers/mtd/nand/Makefile       |  1 +
>>>>  drivers/mtd/nand/mxs_nand_spl.c | 37
>>>> ++++++++++++++++++++++++++++++++++++-
>>>>  drivers/mtd/nand/nand_base.c    |  3 ++-
>>>>  include/linux/mtd/rawnand.h     | 10 +++++++---
>>>>  scripts/config_whitelist.txt    |  1 +
>>>>  6 files changed, 51 insertions(+), 5 deletions(-)
>>>>
>>
>>


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list